Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #268 - nested DTO가 Swagger에 잡히지 않는 문제 해결 #271

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

hoonyworld
Copy link
Member

Related issue 🛠

Work Description ✏️

  • nested DTO가 Swagger에 잡히지 않는 문제를 해결했습니다.
  • 패키지명이 겹치는 클래스들이 많을 때나 클래스 이름만으로 식별하기 어려운 경우에 FQN을 사용하면 클래스를 더 명확하게 식별할 수 있습니다.

Trouble Shooting ⚽️

Related ScreenShot 📷

AS-IS

image
  • nestedDTO인 Booking이 잡히지 않습니다.

TO-BE

image
  • nestedDTO인 Booking이 잡혀 스웨거 상에 나오게 됩니다.

Uncompleted Tasks 😅

To Reviewers 📢

hoonyworld and others added 2 commits December 1, 2024 01:41
* [#256] refactor: 생성자 private로 변경

* [#256] fix: 오탈자 수정

* [#256] test(GuestBookingServiceConcurrencyTest): 변경된 필드 테스트에 반영

* [#256] feat: enum custom converter 구현

* [#256] fix(PerformanceImage): 테이블명과 겹치지 않게 공연이미지 변수명 수정

* [#256] feat(GlobalExceptionHandler): MethodArgumentTypeMismatchException handler 등록

* [#256] fix(Performance): 자료형을 tinytext에서 longtext로 수정
Copy link
Collaborator

@hyerinhwang-sailin hyerinhwang-sailin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@hoonyworld hoonyworld changed the title [bug] #268 - nested DTO가 Swagger에 잡히지 않는 문제 해결 [fix] #268 - nested DTO가 Swagger에 잡히지 않는 문제 해결 Dec 1, 2024
Copy link
Collaborator

@hyerinhwang-sailin hyerinhwang-sailin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@hoonyworld hoonyworld merged commit b2825b2 into develop Dec 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] nested DTO가 swagger에서 잡히지 않는 오류
2 participants