[fix] #295 - HttpOnly 쿠키에서 자동으로 refreshToken을 추출해 처리하도록 수정 완료 #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 쿠키에서 바로 리프레쉬 토큰을 추출하기 때문에 Bearer 접두사가 붙지 않음. - 추가적으로 복잡한 로직은 private 메서드로 분리함.
…andler 메서드에 추가 - @CookieValue 어노테이션의 required가 true인데 쿠키 값이 없는 상태에서 요청할 경우 예외 발생
1 task
| ) { | ||
| AccessTokenGetSuccess accessTokenGetSuccess = authenticationService.generateAccessTokenFromRefreshToken(refreshToken); | ||
| AccessTokenGenerateResponse response = authenticationService.generateAccessTokenFromRefreshToken(refreshToken); |
There was a problem hiding this comment.
사소한 부분이긴 한데 상단에 response이름을 살렸던 것처럼
response 대신 accessTokenGenerateResponse 로 적으면 더 통일성 있을 것 같습니다!
There was a problem hiding this comment.
이 부분은 저희가 Controller에서 API 작업 시 응닶 DTO return 시 response 로 네이밍을 써왔어서 통일성있게 response로 적어보았습니다!!
(BookingController 참고하시면 좋을 것 같아요!)
There was a problem hiding this comment.
아하 MemberApi에는
HttpServletResponse httpServletResponse
이런식으로 네이밍을 적으셔서 controller에서도 통일하는 게 좋지 않을까 생각했는데 api와 controller도 네이밍 통일하면 좋을 것 같습니다!
저는 개인적으로는 코드 길이가 조금 길어지더라도 이해도를 위해 dto 네이밍을 그대로 사용하는 방식을 더 선호하는데 어떻게 생각하시나요?
There was a problem hiding this comment.
저도 그대로 사용하는 방식이 좋을 것 같습니다
이 부분 나중에 멀티모듈 도입 시, 한번에 바꾸는거 어떠신가요? (바꿔야 할 네이밍들이 너무 많아서요...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Trouble Shooting ⚽️
스웨거에서 쿠키 테스트 불가능한 문제
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢