copy over tei:constraint/sch:pattern attributes into output Schematron
#731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
over the attributes of an tei:constraint/sch:pattern element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: we were failing to copy over the attributes of a
<sch:pattern>when it was a child of an input<tei:constraint>.P.S. It is worth noting that such attributes, except for
@idwhich we were handling, are quite rare. We do not use them internally, yet. The only ones I found in my entire TEI/, Stylesheets/, and ATOP/ hierarchies were those in the leftover files from my attempt to use abstract patterns to enforce the constraints of declarable elements (which, somewhat shockingly, was 3 years ago to the day, so I did a double-take on the date :-), and a snippet of the XSpec test suite which is in the ATOP library. Thus, unless a user complains, it may not be worth a patch release.