-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated the <re>
element
#2521
Conversation
I have checked this pull request and it all seems like we want it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first comment concerns commit 61247e5: I think it might have been included in this PR by mistake.
Then I made a suggestion so that the recommended value for @type
in the deprecation note matches the examples. @trishaoconnor: if you agree you can click on “commit suggestion” :)
Co-authored-by: Helena Bermúdez Sabel <[email protected]>
Thank you @HelenaSabel for spotting these mistakes. My apologies for not recognising that the commit was added to this PR. That was an accident. I have clicked "commit suggestion" so the deprecation note now matches the examples. |
@trishaoconnor: do you want to try to delete commit 61247e5? I think you could try:
That will delete the commit (without altering the history). But if @sydb, who is assigned to this PR, thinks it’s ok to merge it as it is, fine with me :) |
Yes, the global addition of |
An attempt to ping @GusRiva on the TEI repo. Please ignore. |
Deprecated the
<re>
element for #2487 and in examples replaced<re>
with<entry>
element with the@type
set to "relatedEntry".