-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new att.source and include att.written and att.placement in it #2643
base: dev
Are you sure you want to change the base?
Conversation
and also added note to description of att.placement concerning its use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabineseifert About this, I was just re-reading our minutes from Buenos Aires. It seems we were going to move the classes att.written
and att.placement
into a new class called att.source
. And we left some guidance about parallel cases to help with this. Take a look (you can find the discussion in the F2F minutes by searching for @place
on the posted minutes on the website.)
Also added att.written and att.placement to new att.source
This PR was tied to #2551 but is now tied to #2550. What I did:
What I did not:
|
@sabineseifert — I presume this should currently be considered a DRAFT pull request, yes? Although you have created att.source, you have not added it to the Guidelines. It needs to be included in the list at #DSTECAT in Source/Guidelines/en/ST-Infrastructure.xml. (Starts on line ~864.) Adding it is trivially easy. Adding it in the right place can sometimes be tricky. As for Could someone remind me why we are calling this new class “att.source” — seems confusingly close to att.global.source. Maybe att.renditionLike, att.styleLike, att.sourceDetails, att.specificRendition, or some such? |
Of the just over 100 |
Good idea to mark this as a draft PR which I just did! I looked at the ST-Infrastructure.xml and must confess that I wouldn't know where to add it. But before, we need to settle the question of the name anyway: And concerning the 0 references to the over 100 Thanks, @sydb, for looking into this! |
I am ducking the name issue for the moment, mostly because I do not really know what to call this thing. But as for where in ST the About ½ of our attribute classes are a member of some other class. But of course, an average by accident roughly ½ of those should be in the correct order without intervention. I am working on re-organizing that list and commenting it better, but will not get to check anything in for hours, I am sure. As for adding |
and also added note to description of att.placement concerning its use.
An 'good' example gently guiding the use of
place
in e.g.div
is still missing.