-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed gloss and desc for msName #2645
base: dev
Are you sure you want to change the base?
Conversation
also added German translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. I would prefer “as opposed to a” instead of “instead of any” in
… other object, instead of any formal identification number …
(Approving, because even without this suggested tweak, this is an improvement. But of course, I did not actually read the German. : - )
according to SB's suggestion
Updated description in |
@@ -19,6 +18,7 @@ nominum</soCalled>, or nickname.</desc> | |||
<desc versionDate="2007-05-04" xml:lang="es">contiene cualquier forma de nombre alternativo no estructurado usado para un manuscrito, como por ejemplo <soCalled>ocellus nominum</soCalled>, o sobranombre.</desc> | |||
<desc versionDate="2007-01-21" xml:lang="it">contiene un qualsiasi nome alternativo non strutturato utilizzato per un manoscritto, per esempio <soCalled>ocellus | |||
nominum</soCalled>, o soprannome</desc> | |||
<desc versionDate="2024-12-23" xml:lang="de">enthält einen Eigennamen in Form eines Nomens oder einer Nominalphrase, der für ein Manuskript oder anderes Objekt verwendet wird, anstatt einer formalen Identifikationsnummer oder Klassifikation.</desc> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: I'm a German native speaker but not a librarian
<desc versionDate="2024-12-23" xml:lang="de">enthält einen Eigennamen in Form eines Nomens oder einer Nominalphrase, der für ein Manuskript oder anderes Objekt verwendet wird, anstatt einer formalen Identifikationsnummer oder Klassifikation.</desc> | |
<desc versionDate="2024-12-23" xml:lang="de">enthält einen Eigennamen in Form eines Nomens oder einer Nominalphrase, der für ein Manuskript oder anderes Objekt verwendet wird, anstatt einer formalen Identifikationsnummer oder Signatur.</desc> |
I would replace "Klassifikation" (de) with "Signatur" (de) here for the English term "classmark" (en) is more or a less a synonym of "shelfmark" (en) which is usually translated as "Signatur" (de). "Klassifikation" (de) on the other hand is "classification (scheme)" (en).
according to suggestions by @jamescummings and @sydb.
I also added German translation.
closes #2434
Perhaps someone might update the Spanish, Italian etc.?