Merge pull request #136 from TGSAI/135_devcontainer_updates

Devcontainer fixes
TGSAI · Nov 13, 2024 · 1049080 · 1049080
2 parents 9e21705 + 9649c18
commit 1049080
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -16,10 +16,7 @@ ARG POETRY_VERSION=1.2.2
 ARG CMAKE_MAJOR=3.24
 ARG CMAKE_VERSION=3.24.2
 ARG HYPERFINE=1.15.0
-
-# avoid a torch.distributed error
-# TODO: figure out optimal value
-ENV OMP_NUM_THREADS=1
+ARG CPPLINT_VERSION=1.6.1
 
 # C++/build dependencies
 RUN apt update \
@@ -63,10 +60,7 @@ RUN mkdir -p /venv
 RUN python3.10 -m venv /venv
 ENV PATH="/venv/bin:$PATH"
 
-# FIXME - pip is out of date, find a better way
-RUN pip install --upgrade pip
-
-RUN pip install wheel yapf cpplint zarr xarray
+RUN pip install wheel yapf cpplint==${CPPLINT_VERSION} zarr xarray
 
 RUN pip install \
   "poetry==$POETRY_VERSION" \