Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

141 aws example #142

Merged
merged 8 commits into from
Nov 15, 2024
Merged

141 aws example #142

merged 8 commits into from
Nov 15, 2024

Conversation

blasscoc
Copy link
Collaborator

This is a tool that demonstrates how to slice a mdio file (aws example data) and output a numpy array.

The goal is to demonstrate basic usages of mdio.

BrianMichell
BrianMichell reviewed Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@BrianMichell BrianMichell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, but I think we should address the changes for consistency.

examples/real_data_example/README.md Outdated Show resolved Hide resolved
examples/real_data_example/src/real_data_example.cc Outdated Show resolved Hide resolved
examples/real_data_example/src/seismic_numpy.h Show resolved Hide resolved
examples/real_data_example/src/seismic_numpy.h Outdated Show resolved Hide resolved
BrianMichell
BrianMichell approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@BrianMichell BrianMichell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrianMichell BrianMichell merged commit 838538d into main Nov 15, 2024
6 checks passed
@BrianMichell BrianMichell deleted the 141-aws-example branch November 15, 2024 18:41
@BrianMichell BrianMichell mentioned this pull request Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianMichell BrianMichell BrianMichell approved these changes

Assignees

@BrianMichell BrianMichell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blasscoc @BrianMichell @brian-michell