Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DevContainer Python deps and build speed #73

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Fix DevContainer Python deps and build speed #73

merged 6 commits into from
Aug 20, 2024

Conversation

BrianMichell
Copy link
Collaborator

Resolves #68

  • Pip now installs Zarr and Xarray
  • We now grab the compiled binary for CMake. This is a big speed-up for new builds.

@BrianMichell BrianMichell requested a review from blasscoc August 5, 2024 21:36
@BrianMichell BrianMichell added CI/CD Continuous integration and delivery Improvement Something could be better labels Aug 6, 2024
blasscoc
blasscoc previously requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@blasscoc blasscoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have pyproject.toml, just use poetry in the dev container

@BrianMichell
Copy link
Collaborator Author

@markspec could probably set up the full pyproject.toml. We don't have one right now.

@BrianMichell BrianMichell dismissed blasscoc’s stale review August 14, 2024 01:24

@markspec and I discussed offline. Just pulling with pip should be sufficient.

markspec
markspec approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@markspec markspec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markspec markspec merged commit 44168b1 into main Aug 20, 2024
6 checks passed
@markspec markspec deleted the 68_devcontainer_fix branch August 20, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-michell brian-michell brian-michell approved these changes

@markspec markspec markspec approved these changes

@blasscoc blasscoc blasscoc left review comments

Assignees
No one assigned
Labels
CI/CD Continuous integration and delivery Improvement Something could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev container does not install Python modules
4 participants
@BrianMichell @blasscoc @markspec @brian-michell