Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to CMake #82

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Fixes to CMake #82

merged 3 commits into from
Aug 14, 2024

Conversation

BrianMichell
Copy link
Collaborator

  • Relocate cloud driver variables to be encapsulated in the parent scope guard.
  • Remove unused memory driver from link list.

@BrianMichell BrianMichell added the Improvement Something could be better label Aug 8, 2024
@BrianMichell BrianMichell requested a review from blasscoc August 8, 2024 13:44
@blasscoc
Copy link
Collaborator

I built the tests, they run LGTM

blasscoc
blasscoc approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@blasscoc blasscoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test build and run, LGTM

@blasscoc blasscoc merged commit e480085 into main Aug 14, 2024
6 checks passed
@blasscoc blasscoc deleted the fix_parent_cmake branch August 14, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blasscoc blasscoc blasscoc approved these changes

Assignees
No one assigned
Labels
Improvement Something could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrianMichell @blasscoc