Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include vpc_id and private_subnet_route_table_ids in asg module output #118

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

thiemogries
Copy link
Contributor

PR instructions

  • deploy asg example and check the output

The steps of acceptance

✔ I executed the PR instructions and everything worked.

✔ I checked the requirements for the ticket, and they are matching the PR.

✔ I am satisfied with the code and left annotations if I had some ideas.

@thiemogries thiemogries self-assigned this Jan 22, 2025
@martprog martprog requested a review from xddq January 23, 2025 08:27
Copy link
Contributor

@xddq xddq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiemogries thiemogries merged commit 5666fa1 into main Jan 27, 2025
3 checks passed
@thiemogries thiemogries deleted the feature/asg-output branch January 27, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants