remove readline import from cli_demo.py #357
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused readline import from cli_demo.py
Pull Request Description
In this pull request, we've removed the unused readline import from cli_demo.py.
Changes Made
Removed the import readline line from cli_demo.py.
Reason for Changes
The readline library was imported in cli_demo.py, but was never used in the script. This import sometimes caused an error on certain Windows platforms, where the readline library doesn't work as expected.
Removing this unnecessary import improves the overall compatibility of the script with different platforms and reduces the possibility of encountering import errors. Users will be able to run the script without any additional requirements or modifications related to the readline library.
Testing
After removing the readline import, we ensured that the cli_demo.py script runs successfully without any import errors across different platforms. The functionality of the script remains unaffected by this change.
Please review and let us know if there are any concerns or further changes required.
Thank you!