Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize vroom size #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Parametrize vroom size #3

wants to merge 3 commits into from

Conversation

franla23
Copy link
Member

This pull requests covers the following minor changes:

  • support of VROOM_CONNECTION_SIZE parameter again and removal of hard coded value
  • installation of conda-forge::r-iotools=0.3-2 in sequenza environment as the newer version is not compatible with sequnza=3.0.0
  • update of readme. It now describes that the reference file must not contain alternative chromosomes and must be sorted.

@franla23 franla23 requested a review from priesgo June 11, 2024 15:10
Copy link
Collaborator

@priesgo priesgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing, but it is nothing related to these changes so I am approving it.

This brings two things to discuss:

  1. the nf-core/modules repo is not linked to any particular commit, branch or tag, so this is out of control from our side. This should be in .gitmodules.
  2. I suspect the nf-core module may be genuinely failing now, which would put under question on the usefulness of reusing in this situation. Maybe you could with a quick copy-paste of this gcwiggle module see if you can reproduce the issue locally?

@@ -62,6 +62,9 @@ $ nextflow run tron-bioinformatics/tronflow-copy-number-calling -r <RELEASE|BRAN
Option 2: Download the project and run it as follows...

```bash

git clone --recurse-submodules [email protected]:TRON-Bioinformatics/tronflow-copy-number-calling.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, it would be good to have this in every tronflow repo, but this is obviously very difficult to maintain. Maybe we could have generic instructions when possible in the documentation and keep README files to a minimum. Just thinking aloud... maybe we can discuss in the larger group next week.

@priesgo
Copy link
Collaborator

priesgo commented Jun 14, 2024

@johausmann on your question about reusing from nf-core. I suspect one module from nf-core here may be failing. This may be caused by a change in the dependency tree, which can always happen, but it also shows that reusing nf-core may not protect us from this and on the other hand it may slow us down as fixing it in nf-core is less straightforward than fixing it on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants