-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize vroom size #3
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are failing, but it is nothing related to these changes so I am approving it.
This brings two things to discuss:
- the nf-core/modules repo is not linked to any particular commit, branch or tag, so this is out of control from our side. This should be in
.gitmodules
. - I suspect the nf-core module may be genuinely failing now, which would put under question on the usefulness of reusing in this situation. Maybe you could with a quick copy-paste of this gcwiggle module see if you can reproduce the issue locally?
@@ -62,6 +62,9 @@ $ nextflow run tron-bioinformatics/tronflow-copy-number-calling -r <RELEASE|BRAN | |||
Option 2: Download the project and run it as follows... | |||
|
|||
```bash | |||
|
|||
git clone --recurse-submodules [email protected]:TRON-Bioinformatics/tronflow-copy-number-calling.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, it would be good to have this in every tronflow repo, but this is obviously very difficult to maintain. Maybe we could have generic instructions when possible in the documentation and keep README files to a minimum. Just thinking aloud... maybe we can discuss in the larger group next week.
@johausmann on your question about reusing from nf-core. I suspect one module from nf-core here may be failing. This may be caused by a change in the dependency tree, which can always happen, but it also shows that reusing nf-core may not protect us from this and on the other hand it may slow us down as fixing it in nf-core is less straightforward than fixing it on our side. |
This pull requests covers the following minor changes: