CustomInput - warn option #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when the regex is not valid. Uses it for the username to allow for uncommon usernames that are currently not accounted for with teh regex.
👇 Click on the image for a new way to code review
Legend |
OliEfr
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue that there exist old or generally uncommon login names, whose setup right now is blocked by our regex on the input field. This PR fixes this by implementing a
warnprop for theInputcustom component that still marks the field as valid, even if the regex isn't fulfilled. The PR adjusts the style forwarnInputs to show the color themeswarningcolor and uses the phosphor warning icon. It also adds the new prop to the uname input field in Onboarding and setting page.References
Referenced Issue:
#107 (Closed by this)
Type of change
Further info
Testing
We have 1500+ Users. Please test your changes thoroughly.
npm run testlocallyAdditional Information
npm run testandnpm run lintstill error for me, is that for you guys @OliEfr @C0ntroller the case too?