Add kubectl over socks5 proxy support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladidan
reviewed
Jan 16, 2019
| @@ -129,6 +130,19 @@ func (s *SpdyRoundTripper) dial(req *http.Request) (net.Conn, error) { | |||
| return s.dialWithoutProxy(req.Context(), req.URL) | |||
| } | |||
|
|
|||
| if proxyURL.Scheme == "socks5" { | |||
There was a problem hiding this comment.
use switch with a fallthrough for http, and https, and error for default
erikbryant
reviewed
Feb 1, 2019
| } | ||
|
|
||
| // dialWithoutProxy dials the host specified by url through an http or an https proxy. | ||
| func (s *SpdyRoundTripper) dialWithHttpProxy(requestUrl *url.URL, proxyURL *url.URL) (net.Conn, error) { |
There was a problem hiding this comment.
The name of the function and the name in the comment do not match.
erikbryant
reviewed
Feb 1, 2019
| } | ||
|
|
||
| // dialWithoutProxy dials the host specified by url through a socks5 proxy. | ||
| func (s *SpdyRoundTripper) dialWithSocks5Proxy(requestUrl *url.URL, proxyURL *url.URL) (net.Conn, error) { |
There was a problem hiding this comment.
Function name and comment do not match.
|
@drastawi are you planning on getting this PR finished? I'm also trying to make use of a proxy for kubectl and look forward to seeing this get merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The PR allows fo call kubectl commands like exec over socks5 proxy.
Which issue(s) this PR fixes:
Fixes #kubernetes#58065
Special notes for your reviewer:
The pr will only impact only proxies with scheme
socks5. The proxy connections withhttp,httpsare unchanged.Tests are not implemented, will need help with mocking the socks 5 setup.
Does this PR introduce a user-facing change?: