Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add function to read and format diann pg files #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add function to read and format diann pg files #22

wants to merge 3 commits into from

Conversation

ltatka
Copy link

@ltatka ltatka commented Dec 6, 2024

Function to read diann tsv files and format them for the test_enrichment function.

@wfondrie wfondrie self-requested a review December 6, 2024 23:00
wfondrie
wfondrie requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@wfondrie wfondrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the docstring comment and add a unit test for this and it should be good to go.

gopher/parsers/tabular.py
- Renames the index axis to "Protein".
- Drops unnecessary metadata columns.

Args:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Please use Numpy-Style docstrings https://numpydoc.readthedocs.io/en/latest/format.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfondrie wfondrie wfondrie requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltatka @wfondrie