-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Search events by tags and time #312
base: main
Are you sure you want to change the base?
Conversation
@Tanay-ErrorCode Please merge this now... |
@Tanay-ErrorCode Could you please assign it a level-3 as it had the backend involved. |
@arunimaChintu You have made many unnecessary changes. Only the files related to the search functionality needed to be changed. |
@Doraemon012 Yeah! I tried to make it with the minimal changes... But then, to show the functionality of the search bar I added those extra events, which can be removed when necessary |
@Doraemon012 if you I can remove those uncessary Events... It was just an example to show the working... Not a big deal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arunimaChintu Please explain your changes.
@arunimaChintu I am getting this error while running your code. |
@Tanay-ErrorCode My bad, am adjusting it as quick as possible, and removing these parts mentioned by you... Actually, I am new to this project... |
@Tanay-ErrorCode @Doraemon012 Removed all the unnecessary changes and it filters by titles now... Please merge this now |
What kind of change does this PR introduce?
Closes #298
Screen.Recording.2024-07-04.at.10.26.52.PM.mov
Key Changes:
Search Input Placeholder: Updated to "Search by tags or date...".
Filter Function: filterEvents now filters by tags and date.
Search Logic: handleSearch now uses the updated filterEvents function to filter events based on tags and date.
Search Event Handler: handleKeyPress ensures the search is triggered when pressing "Enter".
Issue Number:
Fixes #
Snapshots/Videos:
Other information