Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #216

Merged
merged 74 commits into from
Feb 19, 2024
Merged

Dev #216

merged 74 commits into from
Feb 19, 2024

Conversation

vinicvaz
Copy link
Collaborator

@vinicvaz vinicvaz commented Jan 18, 2024

  • Add k8s flag to task deploy_mode to fix bugs in production deploy mode
  • Add _shared_storage_usage_in_bytes variable to BasePiece class. It maps the total storage usage by the piece, including all bytes stored in results, reports and xcom folder.
  • Update CLI to accept --dev flag when building docker images, allowing to build pieces using development base images.
  • Update pieces repositories with latest domino image
  • Fix tests in actions
  • Frontend - Workspaces List error message on leave #229

nathan-vm and others added 30 commits January 12, 2024 19:00
Co-authored-by: Vinícius Vaz <[email protected]>
fix: delete workspace from local storage on leave
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b43300f) 75.86% compared to head (a357276) 75.86%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   75.86%   75.86%           
=======================================
  Files          42       42           
  Lines        1438     1438           
=======================================
  Hits         1091     1091           
  Misses        347      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinicvaz vinicvaz marked this pull request as ready for review February 16, 2024 11:32
Copy link
Collaborator Author

@vinicvaz vinicvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend production image is breaking with:
/usr/share/nginx/html/entrypoint.sh: 7: /usr/share/nginx/html/import-meta-env: not found

Copy link
Collaborator Author

@vinicvaz vinicvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple arrays with object object
image

@vinicvaz vinicvaz merged commit 5708c2b into main Feb 19, 2024
7 checks passed
@vinicvaz vinicvaz deleted the dev branch February 19, 2024 14:43
@vinicvaz vinicvaz restored the dev branch February 19, 2024 14:43
@vinicvaz vinicvaz deleted the dev branch February 19, 2024 15:04
@vinicvaz vinicvaz restored the dev branch February 19, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants