Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colcon Test Enhancement: Fix bugs causing colcon test failure #66

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

Yunus-Selim
Copy link
Contributor

Following the merging of test branches #60 and #61, I have discovered that there are some bugs which cause colcon test to fail when vcan is up. This pull request should resolve the issue.

@Yunus-Selim Yunus-Selim requested a review from luca-byte January 2, 2025 15:23
@Yunus-Selim Yunus-Selim self-assigned this Jan 2, 2025
Copy link
Member

@luca-byte luca-byte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luca-byte luca-byte merged commit b312e6e into main Jan 2, 2025
1 check passed
@luca-byte luca-byte deleted the colcon-test-enhancement branch January 2, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants