Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Parameters and Pipeline for MK2 #69

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Modify Parameters and Pipeline for MK2 #69

wants to merge 12 commits into from

Conversation

Yunus-Selim
Copy link
Contributor

Closes #68

@Yunus-Selim Yunus-Selim requested a review from luca-byte January 4, 2025 17:33
@Yunus-Selim Yunus-Selim self-assigned this Jan 4, 2025
@luca-byte
Copy link
Member

I have yet to check the parameters.
I think that we need to further modify the xacro files, so that the arm file is loaded conditionally to the mk version. Moreover probably it would make sense to move the arm parameter to another file, separate from the main xacro parameter file, so that it can be loaded by the arm xacro, without causing errors using mk2 file with different arm parameters

luca-byte
luca-byte requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@luca-byte luca-byte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one modification: currently we are using narrow tracks on MK2.

reseq_ros2/config/agevar_consts_mk2.yaml Outdated Show resolved Hide resolved
reseq_ros2/config/digital_twin_params_mk2.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca-byte luca-byte luca-byte requested changes

Assignees

@Yunus-Selim Yunus-Selim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify MK2 parameters and pipeline to differentiate MK1 and MK2 EnEA.
2 participants
@Yunus-Selim @luca-byte