-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added C++ Example with ported CheesyVisionServer #1
base: master
Are you sure you want to change the base?
Conversation
I know Wait() takes a double value of seconds, and in my experience (which is not in vxWorks) Sleep() takes an integer number of milliseconds, however it is ambiguous as near as I can tell, and could explain the odd behavior I've seen. It may be clearer to change it to Wait(.05); |
I found the docs. sleep is in seconds. On Thu, Apr 17, 2014 at 4:37 PM, DjScribbles [email protected]:
|
Ok, well excellent catch, would you like me to update and submit a new request, or would you like to resolve it on your end? |
Just add another commit that fixes it. If you push to this branch it should
|
Sleep is in seconds, not milliseconds. To keep same resolution, switched to Wait(double seconds).
Ok, done. |
|
||
class CheesyVisionRobot : public IterativeRobot | ||
{ | ||
CheesyVisionServer *server; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your indentation is inconsistent...
Please explicitly make private members private.
class {
public:
...
private:
...
};
Thanks for the pull request! We have a high quality bar (as you would expect), hence the large number of comments. Hopefully we can whip everything into shape quickly. |
I don't want to sound rude, because I don't disagree with any of your feedback, but I don't really have the energy this week to follow through with them; we've had 3 weeks straight of back to back competitions; our season is now over, and I'm trying to get back to the rest of life for a while. You are welcome to make any changes you wish, I'll make some quick comments above, but beyond that, it may be too late before I have the time and energy to go through everything you've suggested. |
As noted on Chief Delphi, I did encounter some problems on our second day of using the ported CheesyVisionServer code, however other teams have used it successfully without any trouble (as did we our first day).