feat: improved the sun tracking of Advanced Solar Panels and improved the statuses of solar panels (mostly related to thunder) #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roelymole
commented
Jan 5, 2025
•
Roelymole
commented
- Shifted the solar panel up slightly so that the pixels are aligned with the rest of the world in the y-axis.
- Removed the excess space in the block outlines of the solar panel part blocks.
- Prevented the solar panel from rotating 360° and thus passing through the pole (limited to 120° of motion i.e. ±60° from horizontal).
- Reduced the generation rate to 10% when the weather is thunder.
- Added translatable strings for thunder/stormy weather.
- Fixed issues where the light source was incorrect (e.g. the Moon during the daytime).
- Made the use of colors more consistent for text components.
- Made solar panels work for different length days.
…east until it is implemented properly in machinelib
…basePos of SolarPanelPartBlockEntity does not appear to be persisted)
… into solarpanels
… into solarpanels
Roelymole
changed the title
Split solar_panel/default_solar_panels to 3 textures in gui/solar_panel/ Make solar panel use the planet textures from gui/celestialbodies/ instead of solar_panel/default_light_sources & solar_panel/moon_light_sources
…r with actual types
… into solarpanels
… into solarpanels
… into solarpanels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.