-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bugfixes for #392, three NullPointerErrors and other inconsistencies #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l screen and corrected parent/grandparent labels when zooming in on the Sun
… into celestialscreen
… into celestialscreen
Roelymole
changed the title
fix: bugfixes for #392 and #389
fix: bugfixes for #392, #389 and #393
Jan 7, 2025
Roelymole
changed the title
fix: bugfixes for #392, #389 and #393
fix: bugfixes for #392, #389, #393 and #390
Jan 7, 2025
Roelymole
changed the title
fix: bugfixes for #392, #389, #393 and #390
fix: bugfixes for #392, #389 and others
Jan 9, 2025
I have moved the commits related to oxygen and suffocation to a separate branch as there ended up being enough of them to warrant their own pull request. |
… and renamed structures folder to structure (1.21)
Prevented passengers of a LanderEntity from being killed by hitting the ground too hard even when landing softly by applying the |
…l screen and corrected parent/grandparent labels when zooming in on the Sun
…mirrored by default
Roelymole
changed the title
fix: bugfixes for #392, #389 and others
fix: bugfixes for #392, three NullPointerErrors and other inconsistencies
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #392
The issue causing items in the firstperson hands to turn translucent was indeed caused by the footprints - the shader color needed to be reset afterwards.
Additionally fixed bugs that had not been reported:
Fixed a NullPointerError which caused a crash when clicking the Sun in the celestial screen. Corrected parent/grandparent labels when zooming in on the Sun which was not possible before due to the crash.
Fixed a NullPointerError which caused a crash when a player dies in oil or sulfuric acid.