Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugfixes for #392, three NullPointerErrors and other inconsistencies #394

Merged
merged 15 commits into from
Feb 3, 2025

Conversation

Roelymole
Copy link
Contributor

@Roelymole Roelymole commented Jan 7, 2025

Fixed #392
The issue causing items in the firstperson hands to turn translucent was indeed caused by the footprints - the shader color needed to be reset afterwards.

Additionally fixed bugs that had not been reported:
Fixed a NullPointerError which caused a crash when clicking the Sun in the celestial screen. Corrected parent/grandparent labels when zooming in on the Sun which was not possible before due to the crash.

Fixed a NullPointerError which caused a crash when a player dies in oil or sulfuric acid.

@Roelymole Roelymole changed the title fix: bugfixes for #392 and #389 fix: bugfixes for #392, #389 and #393 Jan 7, 2025
@Roelymole Roelymole changed the title fix: bugfixes for #392, #389 and #393 fix: bugfixes for #392, #389, #393 and #390 Jan 7, 2025
@Roelymole Roelymole changed the title fix: bugfixes for #392, #389, #393 and #390 fix: bugfixes for #392, #389 and others Jan 9, 2025
@Roelymole
Copy link
Contributor Author

I have moved the commits related to oxygen and suffocation to a separate branch as there ended up being enough of them to warrant their own pull request.

… and renamed structures folder to structure (1.21)
@Roelymole
Copy link
Contributor Author

Prevented passengers of a LanderEntity from being killed by hitting the ground too hard even when landing softly by applying the #minecraft:fall_damage_immune tag to the lander.

@Roelymole Roelymole requested a review from AlphaMode January 31, 2025 13:58
@Roelymole Roelymole changed the title fix: bugfixes for #392, #389 and others fix: bugfixes for #392, three NullPointerErrors and other inconsistencies Feb 3, 2025
@Roelymole Roelymole merged commit 2ff5374 into TeamGalacticraft:main Feb 3, 2025
1 check passed
@Roelymole Roelymole deleted the bugfixes branch February 5, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Items in firstperson hands turn translucent and eventually disappear when on the Moon
1 participant