PlayerHelper: Improvment readability, performance and manage errors #12001
+82
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced the structure and organization of the globalScreenOrientationLocked method to make it more readable - Removed unnecessary comments to streamline the code and improve overall clarity.
… methods: improvment readability and try catch errors
neosis91
changed the title
neosis91
changed the title
Isira-Seneviratne
requested changes
Feb 6, 2025
app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java
Outdated
Show resolved
Hide resolved
MEGABYTE become static variable
- use DateUtils.formatElapsedTime method
remove STRING_FORMATTER not used in helper
ShareASmile
added
player
Isira-Seneviratne
approved these changes
Feb 7, 2025
app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java
Outdated
Show resolved
Hide resolved
| @@ -154,9 +154,6 @@ public void onAudioSessionIdChanged(@NonNull final EventTime eventTime, | |||
| notifyAudioSessionUpdate(true, audioSessionId); | |||
| } | |||
| private void notifyAudioSessionUpdate(final boolean active, final int audioSessionId) { | |||
| if (!PlayerHelper.isUsingDSP()) { | |||
There was a problem hiding this comment.
Why is this check removed?
app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java
Outdated
Show resolved
Hide resolved
…r.java Co-authored-by: Isira Seneviratne <[email protected]>
…r.java Co-authored-by: Isira Seneviratne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Due diligence