Add CellBender v3 support to read_cellbender() function #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
CellBender v3 made some big changes on how the h5 outputs are organised, and also some keys have been renamed. So I modified
read_cellbender()function to support v3 outputs. I used the same structure the originalread_cellbender()function has. My changes might not be very suitable to how the package was structured, so please feel free to make any changes on my PR.Actually, CellBender v3 added a new function to read their h5's in their Python package, you can check their docs here. But I thought that would be better if sctk has v3 support too.
Best,
Batu