Bookingtests #56
Bookingtests #56
Conversation
Will merge once those are fixed. |
| def setUp(self): | ||
| Bookable.objects.create( | ||
| id_str = "b", | ||
| name = "B", | ||
| description = "A bookable" | ||
| ) | ||
|
|
||
| User = get_user_model() | ||
| User.objects.create_user( | ||
| username = "u", | ||
| password = "pw" | ||
| ) |
There was a problem hiding this comment.
I'd recommend not creating test data in setUp, it will annoy you when you decide to test something that requires a different setup. It's better to call some simple functions at the start of each test.
| 'bookable': 'b' | ||
| } | ||
|
|
||
| c.login(username='u', password='pw') |
There was a problem hiding this comment.
And this is why you want to create your test data inside your tests. You'd want to avoid using these hardcoded strings.
| c.login(username='u', password='pw') | ||
| response = c.post('/booking/book/b', postdata) | ||
|
|
||
| self.assertEqual(response.status_code, 201) |
There was a problem hiding this comment.
This doesn't assert a whole lot. It would be great to check that a new booking was created.
| self.assertEqual(response.status_code, 403) | ||
|
|
||
|
|
||
| def test_cant_book_too_far_in_future(self): |
There was a problem hiding this comment.
I don't think there is any limit set by default, another reason you might want to create your test data inside the test
| self.assertEqual(response.status_code, 403) | ||
|
|
||
|
|
||
| def test_cant_book_too_long(self): |
There was a problem hiding this comment.
Same here, no limit set by default
| } | ||
|
|
||
| c.login(username='u', password='pw') | ||
| response = c.post('/booking/book/b', postdata) |
There was a problem hiding this comment.
/booking/book/b ??
I hope you don't intend to allow creating bookings with arbitrary ID's...
Added tests for checking that booking restrictions are enforced. They dont pass at the moment because of bugs in forms.py that I will fix next