Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Overlay): complete refactoring #451

Merged
merged 6 commits into from
Aug 12, 2024
Merged

feat(Overlay): complete refactoring #451

merged 6 commits into from
Aug 12, 2024

Conversation

anlyyao
Copy link
Collaborator

@anlyyao anlyyao commented Aug 11, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #398

相关PR
Tencent/tdesign-common#1869
TDesignOteam/tdesign-api#364

💡 需求背景和解决方案

📝 更新日志

  • feat(Overlay): 新增 Overlay 组件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Aug 11, 2024

完成

Copy link
Collaborator

@HaixingOoO HaixingOoO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Popup.defaultProps = popupDefaultProps
改用useDefaultProps

@anlyyao
Copy link
Collaborator Author

anlyyao commented Aug 12, 2024

Popup.defaultProps = popupDefaultProps 改用useDefaultProps

这里只处理 overlay 组件,其他弹窗组件有改动是跟随overlay api的调整进行调整,只保证其他弹窗组件的正常使用

@HaixingOoO
Copy link
Collaborator

这里只处理 overlay 组件,其他弹窗组件有改动是跟随overlay api的调整进行调整,只保证其他弹窗组件的正常使用

但是defaultProps在React19刪掉了,到時這個沒用也會有警告

@anlyyao
Copy link
Collaborator Author

anlyyao commented Aug 12, 2024

这里只处理 overlay 组件,其他弹窗组件有改动是跟随overlay api的调整进行调整,只保证其他弹窗组件的正常使用

但是defaultProps在React19刪掉了,到時這個沒用也會有警告
其实 mobile react 现在可能连 18 都没适配😂,我的想法是先向把mobile vue对齐,等组件迁移完之后再做18 or 19适配

@HaixingOoO
Copy link
Collaborator

😂都行,不過在現在有的情況下,肯定能改就改了,後續也會方便很多,那就先這樣吧

@anlyyao
Copy link
Collaborator Author

anlyyao commented Aug 12, 2024

/update-common

@anlyyao anlyyao merged commit d3def5e into develop Aug 12, 2024
6 checks passed
@anlyyao anlyyao deleted the refactor/overlay branch August 12, 2024 04:15
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【Overlay新组件】任务单
2 participants