Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(statistic): decimalPlaces=0时数值动画期间精度错误 #3327

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix(statistic): decimalPlaces=0时数值动画期间精度错误 #3327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b09b6d
fix(statistic): decimalPlaces=0时数值动画期间精度错误
huangchen1031 Jan 13, 2025
cb19aaf
fix(statistic): 改为使用getFormatValue方法
huangchen1031 Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/statistic/Statistic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import useIsFirstRender from '../hooks/useIsFirstRender';

import Skeleton from '../skeleton';
import Tween from '../_common/js/statistic/tween';
import { COLOR_MAP } from '../_common/js/statistic/utils';
import { COLOR_MAP, getFormatValue } from '../_common/js/statistic/utils';

export interface StatisticProps extends TdStatisticProps, StyledProps {}

Expand Down Expand Up @@ -85,13 +85,9 @@ const Statistic = forwardRef<StatisticRef, StatisticProps>((props, ref) => {
if (isFunction(format)) {
return format(formatInnerValue);
}
const options = {
minimumFractionDigits: decimalPlaces || 0,
maximumFractionDigits: decimalPlaces || 20,
useGrouping: !!separator,
};

// replace的替换的方案仅能应对大部分地区
formatInnerValue = formatInnerValue.toLocaleString(undefined, options).replace(/,|，/g, separator);
formatInnerValue = getFormatValue(formatInnerValue, decimalPlaces, separator);

return formatInnerValue;
}, [innerValue, decimalPlaces, separator, format]);
Expand Down
Loading