Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the usage of Endpoint #60

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Simplify the usage of Endpoint #60

merged 1 commit into from
Nov 27, 2023

Conversation

iyangsj
Copy link
Collaborator

@iyangsj iyangsj commented Nov 27, 2023

  • Supports forcibly closing a endpoint
  • When closing a connection, all its streams are forcefully closed first
  • Once a connection is marked as closed, all its remaining internal events will no longer be processed

@iyangsj
Simplify the usage of Endpoint
4a69ec0 
- Supports forcibly closing a endpoint
- When closing a connection, all its streams are forcefully closed first
- Once a connection is marked as closed, all its remaining internal
  events will no longer be processed
@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (fd20849) 95.06% compared to head (4a69ec0) 95.03%.

Files Patch % Lines
src/endpoint.rs 90.81% 9 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #60      +/-   ##
===========================================
- Coverage    95.06%   95.03%   -0.03%     
===========================================
  Files           47       47              
  Lines        31254    31315      +61     
===========================================
+ Hits         29711    29761      +50     
- Misses        1543     1554      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wangfuyu
wangfuyu approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@wangfuyu wangfuyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangfuyu wangfuyu merged commit ed07b66 into Tencent:develop Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangfuyu wangfuyu wangfuyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iyangsj @codecov-commenter @wangfuyu