Skip to content

Commit

Permalink
Fix for copying binary files in gulp 5.
Browse files Browse the repository at this point in the history
Gulp5 requires passing `encoding: false` when copying binary files to prevent re-encoding as utf8.
  • Loading branch information
na9da committed Nov 29, 2024
1 parent 3f0ab29 commit 78e4745
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ gulp.task("copy-terriajs-assets", function () {
var destPath = path.resolve(__dirname, "wwwroot", "build", "TerriaJS");

return gulp
.src([sourceGlob], { base: terriaWebRoot })
.src([sourceGlob], { base: terriaWebRoot, encoding: false })
.pipe(gulp.dest(destPath));
});

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"fork-ts-checker-notifier-webpack-plugin": "^6.0.0",
"fork-ts-checker-webpack-plugin": "^6.0.0",
"fs-extra": "^7.0.1",
"gulp": "^4.0.0",
"gulp": "^5.0.0",
"husky": "^8.0.3",
"is-subdir": "^1.2.0",
"json5": "^2.1.0",
Expand Down

0 comments on commit 78e4745

Please sign in to comment.