Merge pull request #713 from TerriaJS/gulp5-fix-bin-copy

Fix for copying binary files in gulp 5.
TerriaJS · Nov 29, 2024 · eb7fa4a · eb7fa4a
2 parents 3f0ab29 + 2f53b9f
commit eb7fa4a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,10 @@
 # Change Log
 
+#### next release (0.2.3)
+
+- Upgraded gulp to version 5
+  - Gulp 5 defaults to encoding copied files as utf-8, had turn off encoding by setting `encoding: false` to correctly copy binary assets from dependencies.
+
 ### `0.2.2`
 
 **2024-11-22**

diff --git a/gulpfile.js b/gulpfile.js
@@ -164,7 +164,7 @@ gulp.task("copy-terriajs-assets", function () {
   var destPath = path.resolve(__dirname, "wwwroot", "build", "TerriaJS");
 
   return gulp
-    .src([sourceGlob], { base: terriaWebRoot })
+    .src([sourceGlob], { base: terriaWebRoot, encoding: false })
     .pipe(gulp.dest(destPath));
 });
 

diff --git a/package.json b/package.json
@@ -60,7 +60,7 @@
     "fork-ts-checker-notifier-webpack-plugin": "^6.0.0",
     "fork-ts-checker-webpack-plugin": "^6.0.0",
     "fs-extra": "^7.0.1",
-    "gulp": "^4.0.0",
+    "gulp": "^5.0.0",
     "husky": "^8.0.3",
     "is-subdir": "^1.2.0",
     "json5": "^2.1.0",