Skip to content

Commit

Permalink
Use encoding: false when copying files using gulp.
Browse files Browse the repository at this point in the history
Assets we copy from third party libs include binary files like images, wasm builds etc.
Gulp5 by default re-encodes copied files as utf-8 which breaks copying of binary files.
By, setting `encoding: false` gulp treats all copied files as binary,
reverting to the previous behaviour.
  • Loading branch information
na9da committed Nov 29, 2024
1 parent e467c79 commit f243345
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ gulp.task("copy-cesium-workers", function () {

return gulp
.src([path.join(cesiumWorkersRoot, "**")], {
base: cesiumWorkersRoot
base: cesiumWorkersRoot,
encoding: false
})
.pipe(gulp.dest("wwwroot/build/Cesium/build/Workers"));
});
Expand All @@ -95,7 +96,8 @@ gulp.task("copy-cesium-thirdparty", function () {

return gulp
.src([path.join(cesiumThirdPartyRoot, "**")], {
base: cesiumThirdPartyRoot
base: cesiumThirdPartyRoot,
encoding: false
})
.pipe(gulp.dest("wwwroot/build/Cesium/build/ThirdParty"));
});
Expand All @@ -109,7 +111,8 @@ gulp.task("copy-cesium-source-assets", function () {

return gulp
.src([path.join(cesiumAssetsRoot, "**")], {
base: cesiumAssetsRoot
base: cesiumAssetsRoot,
encoding: false
})
.pipe(gulp.dest("wwwroot/build/Cesium/build/Assets"));
});
Expand Down

0 comments on commit f243345

Please sign in to comment.