Integration with Scaffold-stark: Updated develop branch to use latest version of scaffold-stark

[michojekunle]

Integration with Scaffold-stark: Updated develop branch to use latest version of scaffold-stark

Fixes #93

Types of change

• Feature
• Bug
• Enhancement

Comments (optional)

[michojekunle]

Hi @gianalarcon I've made the requested changes regarding this issue #93 linked to this PR #111

Please review

[gianalarcon]

yarn compile & yarn test not working

[michojekunle]

referral codes: OPBDFRSU J3KE0YMR

@michojekunle

Thank you ser

[michojekunle]

Hi @gianalarcon It just seems like I'm stuck here i think it's the api production uri I'm missing from the env

[gianalarcon]

DM on discord pls https://discord.gg/bWuQFHHA

[michojekunle]

DM on discord pls https://discord.gg/bWuQFHHA

Alright, done

[Buuh2511]

• Put text as a text-center here pls
  

• It will take a short while to see the balance, it is going from 0 to ...STRK, during this time do loading as a Spiner

Then, everything is working for now, I will check more round in morning tomorrow

[Buuh2511]

• Put text as a text-center here pls
  
• It will take a short while to see the balance, it is going from 0 to ...STRK, during this time do loading as a Spiner

Then, everything is working for now, I will check more round in morning tomorrow

Also need to implement for Select Token Modal

[michojekunle]

Hi @Buuh2511

I've now added in both pages (deposit and withdrawal) and the select token modal the loading spinner while fetching token balances

Please review

[Buuh2511]

Spiner just keep loading, cant get balance in somtime

Need to fix alignment

When try to connect wallet without extensions going got bug

Got an error when try to connect wallet but still havent connected yet at the first time launch app

[michojekunle]

Spiner just keep loading, cant get balance in somtime

Need to fix alignment

When try to connect wallet without extensions going got bug

Got an error when try to connect wallet but still havent connected yet at the first time launch app

For the loading spinner it's only when I'm not connected that it keeps showing spinning or whether there's an error fetching the balance it shows the spinning

here first cause my wallet is not connected yet
PS: I refreshed the page

And then here where my wallet is now reflected as connected after complete page load and I'm not logged in so my marquis balance keeps spinning cause of the error fetching my balance

• Fixed the last two bugs

• Fixed this alignment also
  

[michojekunle]

Hi, Gm @Buuh2511

Please review

[Buuh2511]

• got this error when try to connect walllet without extension
  

• "PS: I refreshed the page" : so, we need to keep connection after reload page, better ux

• Cant close modal when click on left and right of screen, only close when click on top and bottom of screen
  

[michojekunle]

• got this error when try to connect walllet without extension
  
• "PS: I refreshed the page" : so, we need to keep connection after reload page, better ux
• Cant close modal when click on left and right of screen, only close when click on top and bottom of screen
  

Alright Gm @Buuh2511

• So, the first error means that the wallet is not installed in the current user browser that is the connector (argent or braavos) is not found

• yes the connection is kept, it just takes a little time to restore the connection locally nextjs dev server loading speed

• Alright will look into this last error now for the modal

[Buuh2511]

• got this error when try to connect walllet without extension
  
• "PS: I refreshed the page" : so, we need to keep connection after reload page, better ux
• Cant close modal when click on left and right of screen, only close when click on top and bottom of screen
  

Alright Gm @Buuh2511

• So, the first error means that the wallet is not installed in the current user browser that is the connector (argent or braavos) is not found
• yes the connection is kept, it just takes a little time to restore the connection locally nextjs dev server loading speed
• Alright will look into this last error now for the modal

"PS: I refreshed the page" : so, we need to keep connection after reload page, better ux
i mean when switch between deposit and withdraw page, connection should be kepth

[michojekunle]

• got this error when try to connect walllet without extension
  
• "PS: I refreshed the page" : so, we need to keep connection after reload page, better ux
• Cant close modal when click on left and right of screen, only close when click on top and bottom of screen
  

Alright Gm @Buuh2511

• So, the first error means that the wallet is not installed in the current user browser that is the connector (argent or braavos) is not found
• yes the connection is kept, it just takes a little time to restore the connection locally nextjs dev server loading speed
• Alright will look into this last error now for the modal

"PS: I refreshed the page" : so, we need to keep connection after reload page, better ux
i mean when switch between deposit and withdraw page, connection should be kepth

Alright will look into this too

[michojekunle]

Hi @Buuh2511

• I think the wallet connection kept works well with braavos wallet, this only comes up with argent wallet in this case any time the dapp wants to reestablish a connection to argent wallet it prompts users to reenter their passwords to unlock their argent wallet and I read about that in this issue Feature Request: Expose Wallet Lock State & Disconnect Event starknet-io/get-starknet#192, which a user will most likely reject there and when the wallet is locked the dapp cannot reestablish connection with the wallet

[michojekunle]

• Also I have now fixed the invitation modal to close on click on the sides @Buuh2511

Please Review

[Buuh2511]

Many thanks for your contribution ! @michojekunle

[michojekunle]

Many thanks for your contribution ! @michojekunle

Thank you so much @gianalarcon @Buuh2511 for the opportunity to contribute, It's really nice contributing to this project and working with you guys 🙌🏾❤️, Really learnt a lot working on this 💯

Looking forward to contributing more 🚀🚀