draft PR #143
Closed
draft PR #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianalarcon
requested changes
Jan 26, 2025
| @@ -15,6 +15,7 @@ pub mod MarquisGame { | |||
| }; | |||
|
|
|||
| use core::num::traits::Zero; | |||
| use core::option::Option::{None, Some}; | |||
There was a problem hiding this comment.
We are already handling Option/Some/None in other sections of the code, and we dont have to import these libs
|
|
||
| // Determine if the session is free or paid | ||
|
|
||
| let (play_token, play_amount) = match (option_token, option_amount) { |
There was a problem hiding this comment.
Cairo doestn handle Some and None like this. This is not the syntax
There was a problem hiding this comment.
let me go through the documentation. i'm currently on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve function signatures #140
having issues with scarb build
Types of change
Comments (optional)