Odb defin scan parse fix #6587
Merged
Odb defin scan parse fix #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliberty
approved these changes
Jan 23, 2025
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Matt Liberty <[email protected]>
Signed-off-by: Matt Liberty <[email protected]>
openroad-ci
force-pushed
the
odb-defin-scan-parse-fix
branch
from
5d3a617 to
6486e40
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@fgaray there was some confusion over the proper syntax in the parser for scan chain start/stop. I've fixed it and your test case based on a production example. |
|
Thank you @maliberty ! Yeah, I don't have production tests at the moment but this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.