negative nums can also be sorted by radix_sort_2 now #1384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goksuko
requested review from
Panquesito7,
tjgurwara99 and
alexpantyukhin
as code owners
realstealthninja
requested changes
Mar 15, 2024
| free(output); | ||
| } | ||
|
|
||
| // Reverse counting sort according to the digit represented by place | ||
| void reverseSort(int *arr2, int neg, int place) |
There was a problem hiding this comment.
since arr2 is a parameter i think its fine to just use arr
same with all the others
|
|
||
| free(arr); | ||
| return 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before the change, the program was able to sort only positive numbers. Now it can sort both negative and positive numbers.
References
original radix_sort_2 document used
Checklist
Notes: negative nums can also be sorted by radix_sort_2 now