Minor feature additions #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covers1624
requested changes
Mar 3, 2024
| @@ -24,6 +27,10 @@ public ItemMultipart(Properties properties) { | |||
| @Nullable | |||
| public abstract MultiPart newPart(MultipartPlaceContext context); | |||
|
|
|||
| protected List<MultiPart> newParts(MultipartPlaceContext context) { | |||
There was a problem hiding this comment.
Should we use Collection here instead of list? Do we need to enforce an order?
There was a problem hiding this comment.
Done. Will also change TileMultipart.canPlaceParts to intake Iterable<MultiPart> instead of list to match everything else.
| public boolean canAddPart(MultiPart part) { | ||
| if (part instanceof SlottedPart) { | ||
| int mask = ((SlottedPart) part).getSlotMask(); | ||
| public boolean canAddParts(Iterable<MultiPart> parts) { |
There was a problem hiding this comment.
We probably need to validate that the slotted parts in this list don't overlap. I.e Someone tries to add 2 parts in the same slot.
There was a problem hiding this comment.
Done. Now, we first build combined mask of all new parts, ensuring no overlap. Then we check that against the existing part list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TileMultipart#markShapeChange()