Unicode fix #6
Open
Unicode fix #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improving unicode support
fixed comment
fixing another unicode problem when PGP encrypting mails…
TheGreatGooo
reviewed
Jan 7, 2024
| @@ -469,7 +469,7 @@ def encrypt_all_payloads_mime( message, gpg_to_cmdline ): | |||
|
|
|||
| def encrypt_payload( payload, gpg_to_cmdline, check_nested = True ): | |||
|
|
|||
| raw_payload = payload.get_payload(decode=True) | |||
| raw_payload = payload.get_payload().encode() | |||
There was a problem hiding this comment.
why remove the decode here? Sounds like this is required to support mime based encodings like base64 encoded messages, ect..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor fix to mitigate the following problem:
the gpg-mailgate.py works nicely as long emails contain only ascii chars:
date | mail -s Test [email protected]nicely encodes the mail, if a respective gpg key is present.However, if you did something like this:
echo "German text may contain letters like ÄäÖöÜüß and others" | mail -s Test [email protected]it will fail, as smtp.sendmail only accepts ascii strings OR byte data.This patch fixes that problem.