-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added french translations for the queries.json #183
base: 1.5
Are you sure you want to change the base?
Conversation
Note that "vérifier la météo", "Comment se porte l'économie", "qui a gagné" and "Temps de jeu" are the only one i manually checked, the rest are google translated, i will check the nexts day for new activities to get an accurate translation, because else it probably won't detect them. Also added weather search
I assume these are tested and not just direct translations from what are there, since they might use some different wording |
The one i could test ("vérifier la météo", "Comment se porte l'économie", "qui a gagné", "Temps de jeu" and "Trouver un endroit à découvrir") i tested them, and yeah most of them have one or two different words. the rest i didn't tested them yet, made this today and could only test the ones that microsoft proposed me, so in the next few days i will update the PR with what i can get |
I can confirm that the sentences "Faites vos achats plus vite" works |
Yes please, most of them are just google translated, the only ones i could confirm are the correct names are the one that i mentioned on the first commit (appart from "qui a gagné", for some reason it's still output the question as the queries even though it's the correct name |
Fixed the titles mentionned by @Kornion , and modified some queries to be more local (for example replaced sp 500 with cac 40, or the football team with a french one)
poste à pourvoir, escapade et actualité
I am still trying to update the queries.json, but i am having some trouble because microsoft keep giving me the same tasks. |
@serzak51 Your work is awesome! Here's some additional promotions I could find: {
"title": "Trouver tous les articles de votre liste d'achats",
"queries": [
"Acheter PS5",
"Acheter Xbox",
"Offres sur les chaises"
]
},
{
"title": "Aventure au Serengeti",
"queries": [
"Parc national Serengeti"
]
},
{
"title": "Valises vite faites",
"queries": [
"Choses à emmener en voyage"
]
} |
If there's not any update for this, I shall merge this into the 1.5 branch, thank you all for your contributions! |
The queries were made for the english version of microsoft reward, but not for other languages, so if the activities are in another language, then it won't detect them.
I inputted the queries into google translation and put them back here, and ajusted the ones i knew to match the activities name. I did the ones i could today, i will update the pull request in the next few days with the ones that i can get (i got a ban wave, most of my accounts got randomly banned, so i'm cautious around this for now)
I also got a new search name about the meteo that wasn't in the english version (see the last one), so you might wanna check that out