Fix for The List cards and Commander cards #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2024 16:39
Replace the "Commander: " prefix with a " Commander" suffix on the Edition
|
I have more up to date changes in the scryfall branch. I can merge the fix into main for now though |
|
Oh nice! I didn't check out the other branch, this is literally the first activity I've had on github =) |
|
Looks like there's a build problem. Will have to look at this later |
|
No worries, appreciate the quick look at the request!
…On Tue, Mar 5, 2024 at 4:58 PM ThePieBandit ***@***.***> wrote:
Looks like there's a build problem. Will have to look at this later
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2ZFQY2E4GMXDOAXY5IYXZ3YWZEZBAVCNFSM6AAAAABEH7OSICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZG43TQMBXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yeah that other branch is a pseudo rewrite. It's much cleaner. I need to
replace the main branch with it soon.
…On Tue, Mar 5, 2024, 5:56 PM GHJebus ***@***.***> wrote:
Oh nice! I didn't check out the other branch, this is literally the first
activity I've had on github =)
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOTAVL4YMPLCC46HJZEE4P3YWZES5AVCNFSM6AAAAABEH7OSICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZG43TMNJRGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
the github action I was using to build a release is no longer working. I am going to close this, I've fixed it in the scryfallData branch which will soon become main. I appreciate your contribution though! I hadn't made the edition update for the list yet, so I added that to the replacements.config in the scryfallData branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCG output CSV with 'Commander: ' and Deckbox expects ' Commander'. TCG also outputs the Edition as 'The List Reprints' and Deckbox expects just 'The List' as the edition.
These changes address both issues for easier direct importing after executing tcg-to-deckbox.