Merge pull request #620 from TheTrackerCouncil/fix-tracker-hint

Fix tracker incorrectly classifying items in dungeons for hints
TheTrackerCouncil · Dec 17, 2024 · 701dc8d · 701dc8d
2 parents 00924ab + fa75bf8
commit 701dc8d
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/TrackerCouncil.Smz3.SeedGenerator/Generation/GameHintService.cs b/src/TrackerCouncil.Smz3.SeedGenerator/Generation/GameHintService.cs
@@ -468,10 +468,15 @@ private LocationUsefulness CheckIfLocationsAreImportant(List<World> allWorlds, I
                 {
                     numCrystalsNeeded = world.Config.GanonsTowerCrystalCount;
                 }
-                var currentCrystalCount = world.RewardRegions.Count(d =>
+
+                var possibleCrystalRewards = world.RewardRegions.Where(d =>
                     d.RewardType is RewardType.CrystalBlue or RewardType.CrystalRed && sphereLocations.Any(l =>
-                        l.World.Id == world.Id && l.Id == s_dungeonBossLocations[d.GetType()])) + (ignoredReward == null ? 0 : 1);
-                if (currentCrystalCount < numCrystalsNeeded)
+                        l.World.Id == world.Id && l.Id == s_dungeonBossLocations[d.GetType()])).Select(x => x.Reward).ToList();
+                if (ignoredReward != null && !possibleCrystalRewards.Contains(ignoredReward))
+                {
+                    possibleCrystalRewards.Add(ignoredReward);
+                }
+                if (possibleCrystalRewards.Count < numCrystalsNeeded)
                 {
                     return LocationUsefulness.Mandatory;
                 }