Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sass when tracking things that are likely misheard #627

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

MattEqualsCoder
Copy link
Collaborator

@MattEqualsCoder MattEqualsCoder commented Dec 19, 2024

Goal here is to still have some tracker sass when she mishears things, but hopefully lower the amount of scenarios where people don't realize that tracker did something until later.

Fixes #586
Fixes #585

CPColin
CPColin previously approved these changes Dec 19, 2024
Vivelin
Vivelin previously approved these changes Dec 19, 2024
Copy link
Member

@Vivelin Vivelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "Hey tracker, force [...]" it should be "Hey tracker, please, I'm begging you, [...]"

@MattEqualsCoder
Copy link
Collaborator Author

Haha. Honestly, I could swap it with something like that. I was worried that force/sudo may be too short to really prevent a lot of mistracking.

@MattEqualsCoder MattEqualsCoder dismissed stale reviews from Vivelin and CPColin via 0d7d82c December 20, 2024 03:21
Copy link
Member

@Vivelin Vivelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we should randomize the argument that Tracker suggests, since we support multiple. Maybe we should have a method somewhere that can format/generate a voice command? But that could be done later, too.

@MattEqualsCoder
Copy link
Collaborator Author

I did think about that, but my concern was that because we have multiple options to give variety to what people can say easily, some combinations may be awkward. For example "Hey Tracker, would you please, kraid is alive" isn't really grammatically correct.

@MattEqualsCoder MattEqualsCoder merged commit 6b760fa into main Dec 20, 2024
2 checks passed
@MattEqualsCoder MattEqualsCoder deleted the tracker-sass-updates branch December 20, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass When Autotracking Sass for Marking Cleared Locations
3 participants