Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Support nested generics #20 #21

Merged
merged 20 commits into from
Jan 6, 2025
Merged

fix Support nested generics #20 #21

merged 20 commits into from
Jan 6, 2025

Conversation

nrbnlulu
Copy link
Contributor

fix #20

@nrbnlulu
Copy link
Contributor Author

@ThirVondukr RFR

nrbnlulu
nrbnlulu commented Dec 29, 2024
View reviewed changes
tests/features/test_generics.py
assert instance.service.b.dependency == MEANING_OF_LIFE_STR


async def test_can_resolve_generic_class_without_parameters() -> None:
Copy link
Contributor Author

@nrbnlulu nrbnlulu Dec 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to find the usecase where I needed this.

Copy link
Contributor

@fadedDexofan fadedDexofan Jan 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrbnlulu TypeVar with default in new Python versions or all impls (after #22) for generic interface

nrbnlulu
nrbnlulu commented Jan 5, 2025
View reviewed changes
aioinject/_features/generics.py Outdated Show resolved Hide resolved
aioinject/_features/generics.py Show resolved Hide resolved
aioinject/context.py Outdated Show resolved Hide resolved
aioinject/context.py Outdated Show resolved Hide resolved
@ThirVondukr ThirVondukr merged commit a4a7b50 into ThirVondukr:main Jan 6, 2025
6 checks passed
@nrbnlulu nrbnlulu deleted the fix-generic-dependencies branch January 6, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThirVondukr ThirVondukr ThirVondukr left review comments

@fadedDexofan fadedDexofan fadedDexofan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support nested generics
3 participants
@nrbnlulu @fadedDexofan @ThirVondukr