Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Push to ghcr.io #198

Merged
merged 1 commit into from
Jan 5, 2025
Merged

feat(ci): Push to ghcr.io #198

merged 1 commit into from
Jan 5, 2025

Conversation

Tiryoh
Copy link
Owner

@Tiryoh Tiryoh commented Jan 5, 2025

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions deployment workflow
    • Enhanced Docker image metadata preparation
    • Improved image tagging with repository owner and timestamp
    • Added support for GitHub Container Registry (ghcr.io) image references

Copy link

coderabbitai bot commented Jan 5, 2025

Walkthrough

The pull request modifies the GitHub Actions deployment configuration by enhancing Docker image metadata preparation. The changes focus on improving image tagging and registry referencing, specifically for the GitHub Container Registry (ghcr.io). The updates introduce a more dynamic and descriptive tagging mechanism that incorporates the ROS distribution and current timestamp, enabling more precise version tracking and deployment management.

Changes

File Change Summary
.github/actions/deploy/action.yml - Added input parameter for GitHub Container Registry image reference
- Updated tags configuration to include ROS distribution and timestamp-based tagging

Poem

🐰 Hopping through GitHub's deploy domain,
With tags that dance and images that flame,
ROS distro stamped with time's embrace,
A rabbit's deployment with digital grace,
Containers tagged, registry's new frame! 🚢


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/actions/deploy/action.yml (1)

69-70: Consider adding SHA-based tags for better reproducibility.

While the current tagging strategy with timestamps is good for tracking deployments chronologically, consider adding Git SHA-based tags for better reproducibility and traceability to source code.

Add this line to the tags section:

  tags: |
    type=raw,value=${{ inputs.ros-distro }}
    type=raw,value=${{ inputs.ros-distro }}-{{date 'YYYYMMDDTHHmm'}}
+   type=sha,prefix=${{ inputs.ros-distro }}-
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ad56ec and 8eff465.

📒 Files selected for processing (1)
  • .github/actions/deploy/action.yml (1 hunks)
🔇 Additional comments (1)
.github/actions/deploy/action.yml (1)

67-67: LGTM! Good addition of GitHub Container Registry support.

The ghcr.io registry reference follows the recommended format and properly uses dynamic values from the GitHub context.

@Tiryoh Tiryoh merged commit 8fa2b8b into master Jan 5, 2025
@Tiryoh Tiryoh deleted the feature/push-to-ghcr branch January 5, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant