-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): Push to ghcr.io #198
Conversation
WalkthroughThe pull request modifies the GitHub Actions deployment configuration by enhancing Docker image metadata preparation. The changes focus on improving image tagging and registry referencing, specifically for the GitHub Container Registry (ghcr.io). The updates introduce a more dynamic and descriptive tagging mechanism that incorporates the ROS distribution and current timestamp, enabling more precise version tracking and deployment management. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/actions/deploy/action.yml (1)
69-70
: Consider adding SHA-based tags for better reproducibility.While the current tagging strategy with timestamps is good for tracking deployments chronologically, consider adding Git SHA-based tags for better reproducibility and traceability to source code.
Add this line to the tags section:
tags: | type=raw,value=${{ inputs.ros-distro }} type=raw,value=${{ inputs.ros-distro }}-{{date 'YYYYMMDDTHHmm'}} + type=sha,prefix=${{ inputs.ros-distro }}-
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/actions/deploy/action.yml
(1 hunks)
🔇 Additional comments (1)
.github/actions/deploy/action.yml (1)
67-67
: LGTM! Good addition of GitHub Container Registry support.The ghcr.io registry reference follows the recommended format and properly uses dynamic values from the GitHub context.
Summary by CodeRabbit