-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test with SwiftWasm 5.6 on CI #475
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7c85175
Build and test with SwiftWasm 5.6 on CI
MaxDesiatov e7b44b4
Create .swift-version
MaxDesiatov ef4eb7b
Specify `main` version for 5.6 jobs
MaxDesiatov 006ddbc
Fix build issue with SwiftWasm 5.6
MaxDesiatov e5dd8fe
Update JavaScriptKit to 0.13.0
kateinoigakukun 991c603
Update to latest JSKit, drop SwiftWasm 5.4/5.5
MaxDesiatov 3f00371
Temporarily disable `macos-11` builds
MaxDesiatov 4b78644
Try to avoid 5.6 crash on Linux
MaxDesiatov b6175c1
Disable broken CI jobs
MaxDesiatov 11ab7d5
Try to use Swift 5.6 in `codecov.yml`
MaxDesiatov ec0a9d7
Disable `codecov.yml` job for now
MaxDesiatov 643ad2b
Fully disable `codecov.yml`
MaxDesiatov 01d4ed1
Clean up `launch.json`
MaxDesiatov a265920
Clarify requirements in `README.md`
MaxDesiatov 3414858
Try nightly-5.6 image in `codecov.yml`
MaxDesiatov b4bf6b5
Try `nightly-5.6-focal` in `codecov.yml`
MaxDesiatov 128c3dc
Add `DEBIAN_FRONTEND=noninteractive` in `codecov.yml`
MaxDesiatov bbe9820
Try `nightly-focal` image in `codecov.yml`
MaxDesiatov 002c41f
Use nightly Swift for GTK Linux builds
MaxDesiatov 812b44f
Avoid using `sudo` when building in a Docker container
MaxDesiatov cc76eb8
Add `build-essential` for Ubuntu Docker jobs
MaxDesiatov 0d3af14
Use `[email protected]` in `codecov.yml`
MaxDesiatov e6a0ede
Update codecov.yml
MaxDesiatov 42d1a21
Remove unused compiler version checks
MaxDesiatov 498b286
Update .github/workflows/codecov.yml
MaxDesiatov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,121 +6,106 @@ on: | |
branches: [main] | ||
|
||
jobs: | ||
swiftwasm_bundle_5_4: | ||
swiftwasm_bundle_5_6: | ||
runs-on: ubuntu-20.04 | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: swiftwasm/swiftwasm-action@v5.4 | ||
- uses: swiftwasm/swiftwasm-action@main | ||
with: | ||
shell-action: carton bundle --product TokamakDemo | ||
|
||
swiftwasm_test_5_4: | ||
swiftwasm_test_5_6: | ||
runs-on: ubuntu-20.04 | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: swiftwasm/swiftwasm-action@v5.4 | ||
- uses: swiftwasm/swiftwasm-action@main | ||
with: | ||
shell-action: carton test | ||
|
||
swiftwasm_bundle_5_5: | ||
runs-on: ubuntu-20.04 | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: swiftwasm/[email protected] | ||
with: | ||
shell-action: carton bundle --product TokamakDemo | ||
|
||
swiftwasm_test_5_5: | ||
runs-on: ubuntu-20.04 | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: swiftwasm/[email protected] | ||
with: | ||
shell-action: carton test | ||
|
||
core_macos_build: | ||
runs-on: macos-11 | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Run the test suite on macOS, build the demo project for iOS | ||
shell: bash | ||
run: | | ||
set -ex | ||
sudo xcode-select --switch /Applications/Xcode_13.0.app/Contents/Developer/ | ||
# avoid building unrelated products for testing by specifying the test product explicitly | ||
swift build --product TokamakPackageTests | ||
`xcrun --find xctest` .build/debug/TokamakPackageTests.xctest || | ||
(cp -r /var/folders/*/*/*/*Tests . ; exit 1) | ||
|
||
rm -rf Sources/TokamakGTKCHelpers/*.c | ||
|
||
xcodebuild -version | ||
|
||
# Make sure Tokamak can be built on macOS so that Xcode autocomplete works. | ||
# Disable macOS builds until Monterey is available on GHA. | ||
# xcodebuild -scheme TokamakDemo -destination 'generic/platform=macOS' \ | ||
# CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO | \ | ||
# xcpretty --color | ||
|
||
cd "NativeDemo" | ||
xcodebuild -scheme iOS -destination 'generic/platform=iOS' \ | ||
CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO | \ | ||
xcpretty --color | ||
cd .. | ||
|
||
./benchmark.sh | ||
|
||
- name: Upload failed snapshots | ||
uses: actions/upload-artifact@v2 | ||
if: ${{ failure() }} | ||
with: | ||
name: Failed snapshots | ||
path: '*Tests' | ||
|
||
gtk_macos_build: | ||
runs-on: macos-11 | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Build the GTK renderer on macOS | ||
shell: bash | ||
run: | | ||
set -ex | ||
sudo xcode-select --switch /Applications/Xcode_13.0.app/Contents/Developer/ | ||
|
||
brew install gtk+3 | ||
|
||
make build | ||
# Disabled until macos-12 is available on GitHub Actions, which is required for Xcode 13.3 | ||
# core_macos_build: | ||
# runs-on: macos-11 | ||
|
||
# steps: | ||
# - uses: actions/checkout@v2 | ||
# - name: Run the test suite on macOS, build the demo project for iOS | ||
# shell: bash | ||
# run: | | ||
# set -ex | ||
# sudo xcode-select --switch /Applications/Xcode_13.0.app/Contents/Developer/ | ||
# # avoid building unrelated products for testing by specifying the test product explicitly | ||
# swift build --product TokamakPackageTests | ||
# `xcrun --find xctest` .build/debug/TokamakPackageTests.xctest || | ||
# (cp -r /var/folders/*/*/*/*Tests . ; exit 1) | ||
|
||
# rm -rf Sources/TokamakGTKCHelpers/*.c | ||
|
||
# xcodebuild -version | ||
|
||
# # Make sure Tokamak can be built on macOS so that Xcode autocomplete works. | ||
# # Disable macOS builds until Monterey is available on GHA. | ||
# # xcodebuild -scheme TokamakDemo -destination 'generic/platform=macOS' \ | ||
# # CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO | \ | ||
# # xcpretty --color | ||
|
||
# cd "NativeDemo" | ||
# xcodebuild -scheme iOS -destination 'generic/platform=iOS' \ | ||
# CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO | \ | ||
# xcpretty --color | ||
# cd .. | ||
|
||
# ./benchmark.sh | ||
|
||
# - name: Upload failed snapshots | ||
# uses: actions/upload-artifact@v2 | ||
# if: ${{ failure() }} | ||
# with: | ||
# name: Failed snapshots | ||
# path: '*Tests' | ||
|
||
# gtk_macos_build: | ||
# runs-on: macos-11 | ||
|
||
# steps: | ||
# - uses: actions/checkout@v2 | ||
# - name: Build the GTK renderer on macOS | ||
# shell: bash | ||
# run: | | ||
# set -ex | ||
# sudo xcode-select --switch /Applications/Xcode_13.0.app/Contents/Developer/ | ||
|
||
# brew install gtk+3 | ||
|
||
# make build | ||
|
||
gtk_ubuntu_18_04_build: | ||
runs-on: ubuntu-18.04 | ||
runs-on: ubuntu-latest | ||
container: | ||
image: swiftlang/swift:nightly-bionic | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Build the GTK renderer on Ubuntu 18.04 | ||
shell: bash | ||
run: | | ||
set -ex | ||
sudo apt-get update | ||
sudo apt-get install libgtk+-3.0 gtk+-3.0 | ||
apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y build-essential libgtk+-3.0 gtk+-3.0 | ||
|
||
make build | ||
|
||
gtk_ubuntu_20_04_build: | ||
runs-on: ubuntu-20.04 | ||
runs-on: ubuntu-latest | ||
container: | ||
image: swiftlang/swift:nightly-focal | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Build the GTK renderer on Ubuntu 20.04 | ||
shell: bash | ||
run: | | ||
set -ex | ||
sudo apt-get update | ||
sudo apt-get install libgtk+-3.0 gtk+-3.0 | ||
apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y build-essential libgtk+-3.0 gtk+-3.0 | ||
|
||
make build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,3 +41,6 @@ Pods/ | |
# SwiftPM | ||
.build | ||
/Packages | ||
|
||
# VS Code | ||
.vscode/launch.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wasm-5.6.0-RELEASE |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why need to update tools version? Can we keep
[email protected]
for older toolchains?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me double-check this once again... I've tried this once and 5.4/5.5 didn't really work with latest
carton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, latest
carton
doesn't support SwiftWasm 5.5 with this package: