New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct envelope period for internal double-resolution. #1341

Merged

TomHarte merged 1 commit into master from AYEnvelopePeriod

Feb 24, 2024

Owner

TomHarte commented Feb 24, 2024 •

edited

Loading

Précis/reminder-to-self:

the AY does its envelopes with 16 levels of volume precision;
the YM doubles that to 32 levels;
my implementation use a half-a-real-AY internal clock divider so that it can generate the YM-style envelopes if asked;
it doubles the programmer-supplied tone and noise periods to make up the difference.

... but, here's the bug: it wasn't doubling the envelope period.

Fixed.

Affects #1339 and possibly resolves it. More testing to do.


          Correct envelope period for internal double-resolution.

c843c39

TomHarte marked this pull request as ready for review

February 24, 2024 20:36

TomHarte merged commit 0ee3b62 into master

11 checks passed

TomHarte deleted the AYEnvelopePeriod branch

February 24, 2024 20:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet