Code

V1 no send no retry#248

Code

Merged

hypesystem merged 22 commits intov1ToothlessGear/node-gcm:v1from v1-no-send-no-retryToothlessGear/node-gcm:v1-no-send-no-retryCopy head branch name to clipboardJun 9, 2016

+215-302

Commits

Commits on Jun 1, 2016

• Remove sendNoRetry from being exposed

  hypesystem

  committed
  22a07f3

  Copy full SHA for 22a07f3

• Rename sendNoRetry -> sendMessage

  hypesystem

  committed
  3d8b4f6

  Copy full SHA for 3d8b4f6

• Remove unnecessary support for no callback (always called with callback!)

  hypesystem

  committed
  81c27c3

  Copy full SHA for 81c27c3

Commits on Jun 2, 2016

• Rewrite sendNoRetry tests to use send with retries: 0

  hypesystem

  committed
  3d18769

  Copy full SHA for 3d18769

• Extract sendMessageWithRetries function

  hypesystem

  committed
  0e6d133

  Copy full SHA for 0e6d133

• Modify retry to use sendMessageWithRetries

  hypesystem

  committed
  008e2fd

  Copy full SHA for 008e2fd

• Added a note about a case that seems odd

  hypesystem

  committed
  cf7b494

  Copy full SHA for cf7b494

• Remove self argument from retry and sendMessageWithRetries

  hypesystem

  committed
  0236fbf

  Copy full SHA for 0236fbf

• Get request body early on, simply pass it through

  hypesystem

  committed
  d125924

  Copy full SHA for d125924

• fix indentation

  hypesystem

  committed
  d4eec16

  Copy full SHA for d4eec16

• Build requestOptions early and pass around (instead of building for each request!

  hypesystem

  committed
  d174ce7

  Copy full SHA for d174ce7

• Reorder functions

  hypesystem

  committed
  e177346

  Copy full SHA for e177346

• Remove an irrelevant return

  hypesystem

  committed
  c558a7c

  Copy full SHA for c558a7c

• Removed redundant tests (now covered by send with retries: 0)

  hypesystem

  committed
  7a0e08e

  Copy full SHA for 7a0e08e

• Dont try to mock sendNoRetry

  hypesystem

  committed
  e0a6969

  Copy full SHA for e0a6969

• Removed some more redundant tests

  hypesystem

  committed
  e8dd0ff

  Copy full SHA for e8dd0ff

• Make all send specs async

  hypesystem

  committed
  9c32fb2

  Copy full SHA for 9c32fb2

Commits on Jun 8, 2016

• Break out of retry if there are no retries left!

  hypesystem

  committed
  79873f8

  Copy full SHA for 79873f8

• Remove this one weird case that is good for naught

  hypesystem

  committed
  20fad62

  Copy full SHA for 20fad62

• Make send() tests work.

  Show description for 41b2d94
  hypesystem

  committed
  41b2d94

  Copy full SHA for 41b2d94

• merge two tests, so the same on now tests sender options and auth key

  hypesystem

  committed
  a1343eb

  Copy full SHA for a1343eb

• Remove two tests that no longer pass (and shouldnt!)

  Show description for 7e55699
  hypesystem

  committed
  7e55699

  Copy full SHA for 7e55699