Fix issues with CMake package configuration when used with vcpkg #110 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0X1A
changed the title
|
I have fixed the problem with osx on CI found here. I think now it passes the ci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use this with vcpkg and encountered issues described in #110 . I've simply applied the changes described in this comment: #110 (comment)
Tested this locally with an overlay-port and was able to build using toml11 as a vcpkg port.'
I won't pretend to know exactly why this was an issue. I'm new to using vcpkg and CMake in general, just know that the fix described in the comment has worked and I did the legwork of applying and testing locally with vcpkg.