Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1777] Nu Runtime app related refactoring #7408

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

mk-software-pl
Copy link
Contributor

@mk-software-pl mk-software-pl commented Jan 10, 2025

Describe your changes

  • NuRuntimeApp based on IOApp
  • ModelClassLoader extends the URLClassLoader
  • the RunnableScenarioInterpreter#run method returns IO[Unit] and doesn't block any thread but completes after the interpreter initiation
  • ActorSystemBasedExecutionContextWithIORuntime renamed to ExecutionContextWithIORuntimeAdapter and adapted to be an general-purpose util (not the designer/server util only)

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Copy link
Contributor

github-actions bot commented Jan 10, 2025

created: #7415
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant