Modernize economy backend to conform to Vault's OfflinePlayer calls. #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlmDl
added
the
Stalled PR
LlmDl
force-pushed
the
feature/uuid_eco_support
branch
from
2badb33 to
17dde84
Compare
Replace Government economy calls to use OfflinePlayer Replace Player Account calls to use UUID Make ReserveAdapter use UUIDs Make VaultAdapter use OfflinePlayer Converts town & nation accounts TODO: convert server_account and war_spoils TODO: major cleanup and removal of redundancies economy overhaul second commit First round of cleanup of everything. Javadoc comments. Add warchest and serveraccount to conversion. economy overhaul third commit Town/Nations BankAccounts work. Towny-Server & WarChest accounts convert and work. Resident accounts do not work. economy overhaul fourth commit this was a terrible idea economy overhaul fifth commit All account types convert. Testing required but it appears to work. Whitespacing cleanup commit. Change from using deprecated method. Revert change in last commit.
LlmDl
force-pushed
the
feature/uuid_eco_support
branch
from
17dde84 to
43af450
Compare
1 task
|
Superseded by #7425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
So as fun as this was (it wasn't) the end result is this:
I'm going to leave this open here in case I do end up working something out.
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.